Add support for ChannelChatMessageDelete and ChannelChatNotification #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It’d be great if this could be merged soon, I am waiting for this for a feature implementation in one of my projects. |
|
Hi @MrLawbreaker, could you squash the last 2 commits (344be58 + 0db19ac) into one to keep the commit history clean? |
Add support for channel.chat.notification Also fixed format to match TwitchLib formatting
|
Is this fine now or should it be just one commit overall? |
|
this is good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #50
Added EventHandler, args and events to client. Models were already in core as mentioned.
Also added namespace
TwitchLib.EventSub.Websockets.Handler.Channel.Chatseeing as there are other namespaces for the other events and a few more chat events still to be implemented.The only other "Chat" event was ChatMessageHandler.cs which is still in the Channel Namespace though.